examples/WatermarkAndRotate/Program.cs (2)

53-58: Consider checking response before writing to file.

If HtmlToPdfAsync returns null or the request fails, CopyToAsync will throw. Adding a null check or try-catch would make the example more robust for users copying this pattern.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@examples/WatermarkAndRotate/Program.cs` around lines 53 - 58, The code
assumes sharpClient.HtmlToPdfAsync(request) always returns a non-null stream;
add a null-check and error handling before calling response.CopyToAsync: verify
the returned response from HtmlToPdfAsync is not null, and wrap the file write
(using resultPath and destinationStream) in a try-catch to log or rethrow a
meaningful error if the request failed or the stream is null; ensure you
dispose/close response and destinationStream properly in the error path.

---

25-34: Potential double-disposal of HttpClientHandler when using BasicAuthHandler.

When authHandler is created (lines 26-28), it takes ownership of handler via InnerHandler = handler. When authHandler is disposed, it will dispose handler as its inner handler. The separate using var handler declaration will then attempt to dispose an already-disposed object.

While HttpClientHandler.Dispose() is typically idempotent, the pattern is fragile. Consider restructuring to avoid the double-dispose:

Suggested fix

-    using var handler = new HttpClientHandler();
-    using var authHandler = !string.IsNullOrWhiteSpace(options.BasicAuthUsername) && !string.IsNullOrWhiteSpace(options.BasicAuthPassword)
-        ? new BasicAuthHandler(options.BasicAuthUsername, options.BasicAuthPassword) { InnerHandler = handler }
-        : null;
-
-    using var httpClient = new HttpClient(authHandler ?? (HttpMessageHandler)handler)
+    var handler = new HttpClientHandler();
+    HttpMessageHandler effectiveHandler = handler;
+    
+    if (!string.IsNullOrWhiteSpace(options.BasicAuthUsername) && !string.IsNullOrWhiteSpace(options.BasicAuthPassword))
+    {
+        effectiveHandler = new BasicAuthHandler(options.BasicAuthUsername, options.BasicAuthPassword) { InnerHandler = handler };
+    }
+
+    using var httpClient = new HttpClient(effectiveHandler, disposeHandler: true)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@examples/WatermarkAndRotate/Program.cs` around lines 25 - 34, The current
pattern double-disposes HttpClientHandler because handler is declared with
"using var handler" and also assigned as InnerHandler of BasicAuthHandler
(authHandler) which will dispose it; fix by only disposing the outermost
handler: remove the separate using on HttpClientHandler and instead create
handler as a plain variable and wrap only the final top-level
HttpMessageHandler/HttpClient in a using; alternatively, instantiate either
BasicAuthHandler or the raw HttpClientHandler inside a single using block so
only the top-level handler (authHandler or handler) is disposed when
constructing HttpClient (refer to HttpClientHandler, BasicAuthHandler,
authHandler, handler, and HttpClient).

test/GotenbergSharpClient.Tests/CrossCuttingOptionsTests.cs (2)

166-171: Consider using async/await instead of .Result.

Using .Result on async methods can cause deadlocks in certain synchronization contexts. While this is generally safe in unit tests without a synchronization context, the idiomatic approach would be to make the test method async.

♻️ Suggested refactor to use async pattern

 [Test]
-public void RotationOptions_SerializesCorrectly()
+public async Task RotationOptions_SerializesCorrectly()
 {
     var options = new RotationOptions
     {
         RotateAngle = RotationAngle.Degrees90,
         RotatePages = PageRanges.Create("1-3")
     };

     var httpContents = options.ToHttpContent().ToList();

-    httpContents.FirstOrDefault(c =>
-        c.Headers.ContentDisposition?.Name == "rotateAngle")!
-        .ReadAsStringAsync().Result.Should().Be("90");
-    httpContents.FirstOrDefault(c =>
-        c.Headers.ContentDisposition?.Name == "rotatePages")!
-        .ReadAsStringAsync().Result.Should().Be("1-3");
+    var angleContent = httpContents.FirstOrDefault(c =>
+        c.Headers.ContentDisposition?.Name == "rotateAngle")!;
+    (await angleContent.ReadAsStringAsync()).Should().Be("90");
+    
+    var pagesContent = httpContents.FirstOrDefault(c =>
+        c.Headers.ContentDisposition?.Name == "rotatePages")!;
+    (await pagesContent.ReadAsStringAsync()).Should().Be("1-3");
 }

Apply similar changes to other serialization tests.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/GotenbergSharpClient.Tests/CrossCuttingOptionsTests.cs` around lines 166
- 171, The test currently blocks on async reads using
ReadAsStringAsync().Result; change the test method (e.g., in
CrossCuttingOptionsTests) to async Task and replace .Result calls with await
ReadAsStringAsync() for the two assertions that inspect httpContents entries
with ContentDisposition.Name "rotateAngle" and "rotatePages"; update the
assertions to await the string results before calling Should().Be("90") and
Should().Be("1-3"), and apply the same async/await pattern to other
serialization tests that use ReadAsStringAsync().Result.

---

240-254: Consider marking integration tests with a category attribute.

These tests require a running Gotenberg instance at localhost:3000 and will fail in CI environments without one. Adding a [Category("Integration")] or [Explicit] attribute would allow these to be excluded from standard unit test runs.

♻️ Suggested addition of category attribute

+[Category("Integration")]
 [Test]
 public async Task HtmlToPdf_WithRotation_Succeeds()
 {

Apply similar changes to HtmlToPdf_WithWatermark_Succeeds.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/GotenbergSharpClient.Tests/CrossCuttingOptionsTests.cs` around lines 240
- 254, The two integration tests HtmlToPdf_WithRotation_Succeeds and
HtmlToPdf_WithWatermark_Succeeds are currently runnable in CI and require a
Gotenberg instance; mark them to be excluded from standard unit runs by adding a
test attribute such as [Category("Integration")] or [Explicit] above each NUnit
[Test] declaration (i.e., annotate the HtmlToPdf_WithRotation_Succeeds and
HtmlToPdf_WithWatermark_Succeeds methods) so test runners can filter or skip
them when integration services are unavailable.